pagure

#2243 Lock the git repo when removing elements from it
Merged by pingou. Opened by pingou.
fix_lock  into  master

Download 2243.patch

This to ensure there are no concurrent writing to the repo which could
create dangling commits.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Pretty please pagure-ci rebuild

I recommend testing this change. If anything, you could just verify that a lock is used by mocking the lock and ensuring that its enter and exit calls happen.

LGTM though (sorry forgot to mention that ☺)

rebased

2 new commits added

  • Add a check that the file lock is being called
  • Always remove the lockfile after using it, just check if it is still present

I'm going to assume the tests added are fine.

Thanks for the review! :)

rebased

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.