#2301 Add a small runworker utility script to start a worker to work on pagure
Merged by pingou. Opened by pingou.
runworker  into  master

Download 2301.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

1 new commit added

  • Add celery to the list of requirements

1 new commit added

  • Add eventlet to the list of dependencies for the tests

Please add a .wait() here to collect the zombie at the end.

Please add a .wait() here to collect the zombie at the end.

Please add a .wait() here to collect the zombie at the end.

please don't use absolute path here. Use sys.executable -m celery instead, so that this script can be used in a virtual env.

Please add a .wait() here to collect the zombie at the end.

rebased

Adjusted :)

When running ./runworker.py, I get "/usr/lib/python2.7/site-packages/celery/bin/celery.pyc: error: unrecognized arguments: --autoreload"

When running ./runworker.py, I get "/usr/lib/python2.7/site-packages/celery/bin/celery.pyc: error: unrecognized arguments: --autoreload"

this arg was removed in celery 4. But I assume pagure is using celery 3.

@zhsj you're right. It works in version 3.

This should be:
celery < 4.0.0

Not sure, there is already in the code a dependency to celery which work for both 3.x and 4.x, I think the issue here is with the runworker, that's the one we need to get working with 4.x

1 new commit added

  • Drop the --autoreload argument

rebased

rebased

It works perfectly fine with celery 4.0 (that's how I actually developed it all).

Let's just drop EL6 support? There's no Celery for it anyway.

Agreed, but there will be more places to adjust so let's do them all at once.

Looks good to me.

Thanks ! :)

Pull-Request has been merged by pingou

Metadata