You are right and this is the right approach, however I think we should be able to reuse the code in pagure.lib.git more precisely the method get_diff_info(repo_obj, orig_repo, branch_from, branch_to) which should do the same algorithm as the one you implemented here but allows re-using existing code :)

Feel free to force-push to the same branch, pagure will update the PR automatically.

And thanks again for catching this one, it's an oversight on my part.

I updated the PR. Please, take a look.

This is looking good, I'll run the tests locally and merge manually to save you the rebase if they pass.

From your tests does it improve the speed?

Thanks!

Yes, it does. It is again about 6s for the load of /commits of that huge gecko-dev repo.

For the previous version, it was 15s.

I had to fix a small coding style error but otherwise tests pass and local test also looks good.

Thanks for the patch!

Commit 7030357b fixes this pull-request