A read through of the code here looks good. :+1: to merge from that perspective.
Jenkins build fails. If it passes for you locally, @pingou, then go ahead and merge I guess.
I'm still trying to get the test suite working here locally on the master branch.
Thanks for the review, I need to get jenkins fixed for the tests I think there are several issues there but I haven't looked much into it.
Pull-Request has been merged by pingou