#2383 Fix call to generate_gitolite_acls and start generalizing the use of self.get_csrf() in the tests
Merged by pingou. Opened by pingou.
fix_tests2  into  master

Download 2383.patch
no initial comment

Thanks, running the tests locally for a final validation and merging :)

Ok, it was missing a simple piece of code (which was done in the py3_work2 branch but that I forgot to port here), so adding it:

--- a/ tests/__init__.py        
+++ b/ tests/__init__.py        
@@ -312,10 +312,11 @@ class Modeltests(unittest.TestCase):
         shutil.rmtree(self.path)
         self.path = None
-    def get_csrf(self, url='/new'):
+    def get_csrf(self, url='/new', output=None):
         """Retrieve a CSRF token from given URL."""
-        output = self.app.get(url)
-        self.assertEqual(output.status_code, 200)
+        if output is None:
+            output = self.app.get(url)
+            self.assertEqual(output.status_code, 200)

Going to include this piece, push and merge.

Thanks for your help!

rebased

Pull-Request has been merged by pingou

Metadata