This expand by default the inline comments in the PR comment section. If some comments are too long you can use the Hide link.
Fixes #1685
Signed-off-by: Clement Verna cverna@tutanota.com
I'm a huge +1 to this (as you might imagine, since I filed the RFE ☺)
The change looks good, I ping @ryanlerch on IRC to see if we can get his ideas about this.
:thumbsup: from me!
Ok, the thing that bugs me about this change is that inline comments are normally about a specific line or section of code. So showing the comment without the context is not very useful most of the time (and adding the context is really not something trivial and there is a ticket for this).
@bowlofeggs do you really think it's worth it?
@pingou yeah I agree that it's not as great without the context, but I think it's still slightly better than hiding it because I think it'll be harder to miss that there were comments.
I wouldn't object if you wanted to wait until it was possible to render the context. I hope that we can get the context into the page soon because I think that's an important feature, especially if someone wants to read about a PR from the past.
Alright, let's give is a try, we can always revert if people complain about it :)
Commit 92dd7b06 fixes this pull-request
Pull-Request has been merged by cverna@tutanota.com
This expand by default the inline comments in the PR comment section. If some comments are too long you can use the Hide link.
Fixes #1685
Signed-off-by: Clement Verna cverna@tutanota.com