#2446 Update the refresh-gitolite action of pagure-admin for the new interface
Merged by pingou. Opened by pingou.
update_pagure_admin  into  master

Download 2446.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

For the record refresh-ssh is broken too; (I tried fixing both here: https://pagure.io/fork/stbuehler/pagure/c/6f84e4a88e17bbb04fbe4c34a02a358bad86bf5f?branch=fixes).

The parameter is named args now instead of _.

This will raise an Exception if there isn't exactly one '/' in args. It might be nice to catch that Exception and provide a friendly error message.

I recommend adding tests that also assert correct behaviour from the new flags.

I recommend further testing, but LGTM otherwise.

will adjust

Added:

            if args.project.count('/') > 1:
                raise pagure.exceptions.PagureException(
                    'Invalid project name, has more than one "/": %s' %
                    args.project)

rebased

I'll see if I can add some more tests otherwise I'll merge as is for now.

rebased

Given the fact that this particular script terminates after running the code, it's not strictly needed. But it's fine as it doesn't do any harm.

Looks fine to me.

Thanks for the review! Will rebase and merge

rebased

Pull-Request has been merged by pingou

Metadata