pagure

#2454 Update the PR ref when the PR is updated
Merged by pingou. Opened by pingou.
fix_local_pr  into  master

Download 2454.patch

Sources: https://git-scm.com/docs/git-push
"""
By having the optional leading +, you can tell Git to update the
ref even if it is not allowed by default (e.g., it is not
a fast-forward.) This does not attempt to merge into .
[...]
To force a push to only one branch, use a + in front of the refspec to push
"""

Fixes https://pagure.io/pagure/issue/2452

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

I think if you will prepend + to the refname, it should do trick!

rebased

rebased

BTW I would appreciate unit test. It's quite important feature
Edited by lslebodn

Agreed on the tests

rebased

rebased

Added tests checking that the refs is changed when the PR is updated.

2 new commits added

  • Update the PR ref when the PR is updated
  • Fix the unit-tests for the change in the My Issue page

2 new commits added

  • Update the PR ref when the PR is updated
  • Fix the unit-tests for the change in the My Issue page

Looks OK to me.

rebased

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.