#2455 Fix branch support for the git blame view
Merged by pingou. Opened by pingou.
fix_blame  into  master

Download 2455.patch

We were not precising the branch to view nor were we doing anything
with the branch name specified.
This commit fixes both points.

Fixes https://pagure.io/pagure/issue/2440

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

why not commit.id?

:thumbsup:

iirc, this API changed at one point (either isn't present in old versions or got removed at one point, not sure anymore).

it's present in master: https://github.com/libgit2/pygit2/blob/master/test/test_blame.py#L123 . But, whatever works in pagure.io is fine

:thumbsup:

@pingou , not merging?

I recommend tests for this change, but LGTM otherwise.

rebased

Added some tests checking that the git hash are different in the two views.

Pull-Request has been merged by pingou

Metadata