#246 Allow editing to a new branch
Merged by pingou. Opened by pingou.
edit_to_branch  into  master

Download 246.patch
no initial comment

Relates to https://pagure.io/pagure/issue/109

I think you would move this up because you use the form values somewhere below, but you don't use them before the place you previously had this. What is the reason for this move then?

Why the change in redirection target?

That's just because in the first work I was doing on this branch I wanted to access form.branch.data in the check I do just below (see if the branch exists), but then I realized I need a branch from and a branch to, the branch from being the branchname as before and the branch to being specified in the form.

So I could place it below as it was before.

Because being redirected to the list of commits means:

  • you can see your new commit added
  • the Pull-request is on that page, so one click away to create the PR for this change

I see, no problem.
I was just being curious.

Makes sense, thanks for the explanation

Looks good to me. :arrow_up_down:

Metadata