PR#2474: Check if there is a group and bail otherwise -

pagure

#2474 Check if there is a group and bail otherwise

Merged Jul 31, 2017 by pingou. Opened Jul 31, 2017 by pingou.

fix_login into master

pingou commented Jul 31, 2017

If there is no group name specified search_groups will return all the
groups, so a list not a single group making the assumption made by the
code invalid and thus leading to a traceback.

Fixes https://pagure.io/pagure/issue/2463

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

cverna commented Jul 31, 2017

There is not tests to be updated for this ? or maybe a new one to be added :)

pingou commented Jul 31, 2017

I don't think we have tests for this due to this being triggered from the openid request.
Would be nice to add some yeah

rebased

Jul 31, 2017

pingou commented Jul 31, 2017

I confirm tests are still passing as is :(

cverna commented Jul 31, 2017

Could use if group: ... instead of the if not ...

cverna commented Jul 31, 2017

same here

cverna commented Jul 31, 2017

Some suggestions but LGTM ;)

rebased

Jul 31, 2017

pingou commented Jul 31, 2017

Thanks :)

Pull-Request has been merged by pingou

Jul 31, 2017

Metadata

Assignee

None

Tags

No Tags

pagure

#2474 Check if there is a group and bail otherwise Merged Jul 31, 2017 by pingou. Opened Jul 31, 2017 by pingou. fix_login into master

Metadata

#2474 Check if there is a group and bail otherwise

Merged Jul 31, 2017 by pingou. Opened Jul 31, 2017 by pingou.

fix_login into master