#248 Base work for eventsource, its server and applied on tickets
Merged by pingou. Opened by pingou.
eventsource  into  master

Download 248.patch
no initial comment

Is this going to be in a later PR?

Why is this running as the git user? I don't think this needs access to the repos?

Isn't this the default?

Maybe even after httpd.service or redis.service, so you're sure those are running before you start this?

Use %{buildroot} so you are consistent

datadir? Since this is code that's run by a server isn't it supposed to be in libexecdir?

I think it would be nicer if you would just make the python file executable and set a shebang line, then you can just do ExecStart=/usr/libexec/pagure-ev/pagure-stream-server.py

What would be other values for this?

If I manage to fix this, yes :)

Well it doesn't use httpd, but +1 on redis

Could be

It does need to read the configuration file to retrieve the info to connect to the redis

It's the other way around, I am consistent by using $RPM_BUILD_ROOT

ok to move it

The url where to connect (http://pagure.io:8080 for example)

Doesn't this need to go through bleach?

It's done later but you're right it should also be done here

You should swap Edited an Sucessfully around

Right, but it would start as root by default, if I'm not mistaken. So you could either use that, or create a new user.
I just don't want this service to be a new point of attack on the data itself :)

You are using $-style for $RPM_BUILD_ROOT, sure, but you are using macros all over the place further: %{_datadir}, %{_unitdir}, ...

The other macros do not exists, the choice between $- and %{} is only possible for the buildrood

You're proposing root instead of git? Oo

Using another user is possible but makes the FS acl management that much more complex...

Oh, that's good to know.

Maybe also show what it could be?

s/send/sent/

Other than a spelling fix, :customs:

Metadata