From cf3d3ad1960bf49662eef9a899e01883b465d152 Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Aug 17 2017 14:09:16 +0000
Subject: Add feature allowing to prevent project creation in the UI only


This allows to forbid project creation in the UI but still allow it via
the API for the person having the API token with the corresponding ACL.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

---

diff --git a/doc/configuration.rst b/doc/configuration.rst
index 7de3b6c..629f7f5 100644
--- a/doc/configuration.rst
+++ b/doc/configuration.rst
@@ -613,7 +613,19 @@ ENABLE_NEW_PROJECTS
 ~~~~~~~~~~~~~~~~~~~
 
 This configuration key permits or forbids creation of new projects via
-the user interface of this pagure instance.
+the user interface and the API of this pagure instance.
+
+Defaults to: ``True``
+
+
+ENABLE_UI_NEW_PROJECTS
+~~~~~~~~~~~~~~~~~~~~~~
+
+This configuration key permits or forbids creation of new projects via
+the user interface (only) of this pagure instance. It allows forbidding
+to create new project in the user interface while letting a set of trusted
+person to create projects via the API granted they have the API token with
+the corresponding ACL.
 
 Defaults to: ``True``
 
diff --git a/pagure/templates/master.html b/pagure/templates/master.html
index d757531..35f6e7d 100644
--- a/pagure/templates/master.html
+++ b/pagure/templates/master.html
@@ -39,7 +39,8 @@
               <li class="nav-item">
                 <a class="nav-link" href="{{ url_for('browse_projects') }}">Browse</a>
               </li>
-              {% if config.get('ENABLE_NEW_PROJECTS', True) %}
+              {% if config.get('ENABLE_NEW_PROJECTS', True) and
+                  config.get('ENABLE_UI_NEW_PROJECTS', True)  %}
                 <li class="nav-item p-l-1">
                   <a class="nav-link" href="{{ url_for('new_project') }}">
                       <span class="oi" data-glyph="plus" title="Create New"
diff --git a/pagure/ui/app.py b/pagure/ui/app.py
index c1c5c5f..9e4f640 100644
--- a/pagure/ui/app.py
+++ b/pagure/ui/app.py
@@ -440,7 +440,8 @@ def new_project():
     """
     user = pagure.lib.search_user(SESSION, username=flask.g.fas_user.username)
 
-    if not pagure.APP.config.get('ENABLE_NEW_PROJECTS', True):
+    if not pagure.APP.config.get('ENABLE_NEW_PROJECTS', True) or \
+            not pagure.APP.config.get('ENABLE_UI_NEW_PROJECTS', True):
         flask.abort(404, 'Creation of new project is not allowed on this \
                 pagure instance')
 
diff --git a/tests/test_pagure_flask_ui_app.py b/tests/test_pagure_flask_ui_app.py
index 8ab1813..5bd53e7 100644
--- a/tests/test_pagure_flask_ui_app.py
+++ b/tests/test_pagure_flask_ui_app.py
@@ -163,6 +163,23 @@ class PagureFlaskApptests(tests.Modeltests):
         self.assertIn(
             'Forks <span class="label label-default">0</span>', output.data)
 
+    @patch.dict('pagure.APP.config', {'ENABLE_UI_NEW_PROJECTS': False})
+    def test_new_project_when_turned_off_in_the_ui(self):
+        """ Test the new_project endpoint when new project creation is
+        not allowed in the UI of this pagure instance. """
+
+        user = tests.FakeUser(username='foo')
+        with tests.user_set(pagure.APP, user):
+            output = self.app.get('/new/')
+            self.assertEqual(output.status_code, 404)
+
+            data = {
+                'description': 'Project #1',
+                'name': 'project-1',
+            }
+
+            output = self.app.post('/new/', data=data, follow_redirects=True)
+            self.assertEqual(output.status_code, 404)
 
     def test_new_project_when_turned_off(self):
         """ Test the new_project endpoint when new project creation is