pagure

#2596 Fix deleting a project when some of the folder are not used
Merged by pingou. Opened by pingou.
fix_delete  into  master

Download 2596.patch

In some setup some of the git repositories are not generated or used so
trying to delete them will end up with a 500 error.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

These 2 asserts are duplicated across multiple tests, maybe it could be worth creating a custom assert method that would take the output data as argument and assert these 2 divs.

LGTM, feel free not to consider the comment :smile:

@cverna I'm going to merge as is, do you want to open a PR adjusting the tests as you are proposing?

I also wonder if some of the tests done in test_delete_repo are not outdated now, would be worth checking I think.

I am Ok for the PR :wink:

Thanks :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.