#2715 Fix displaying nicely the requirement on Sign-of-by and block creating a PR not fullfilling it
Merged by pingou. Opened by pingou.
fix_signed_off  into  master

Download 2715.patch
no initial comment

What about remote PRs? How does this affect that?

What about checking all commits in PR and showing which ones don't have Signed-off-by?

rebased onto 0644d1a18493a0436db2a048036039d7346bbc2b

Added a commit adding the banner for new remote PRs.

Displaying the list of "invalid" commits could end up being problematic if many commits are missing it. I think I'd rather leave this to the user.

@pingou we could add some red/green label on the commits list

But we can sort it out later if someone else will not like existing behavior. LGTM ;)

rebased onto f8c6ddb9d742a181d1b79891026ec6dc9dc96ad5

Thanks for the review!

Let's start with this and we can reconsider/adjust/improve once this is live :)

Pull-Request has been merged by pingou

Metadata