pagure

#2732 Add a diff view for the PR
Merged by pingou. Opened by pingou.
pr_diff  into  master

Download 2732.patch

Fixes https://pagure.io/pagure/issue/2723

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

3 new commits added

  • Drop un-needed print statement
  • Fix not showing the Fork and Edit button on binary files
  • Optimize generating the patch version of a PR

Each commits can be reviewed separately :)

1 new commit added

  • Consolidate the code to simplify it and add diff view on commits

5 new commits added

  • Consolidate the code to simplify it and add diff view on commits
  • Drop un-needed print statement
  • Fix not showing the Fork and Edit button on binary files
  • Optimize generating the patch version of a PR
  • Add a diff view for the PR

It would be good to document the parameters and return type.

It would be good to document the parameters and return type.

I recommend adding docblocks in this file as well.

It'd be good to document the new parameter and its type in the docblock.

LGTM

Isn' t there one already?

Will do :)

In this case it's a flask endpoint and none of them are documented in this way, not sure it make sense to start here.

Will do :)

1 new commit added

  • Add missing docblocks where needed, thanks @bowlofeggs!

I think this is now ready :)

Thanks for the review!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.