#2912 Move the webhook service to be a celery service
Merged by pingou. Opened by pingou.
webhook_service  into  master

Download 2912.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

not a tuple?

are you going to put all the services in task_services.py?

The linux service [0] and the specific rpm [1] should not be needed any more .

[0] https://pagure.io/pagure/blob/master/f/pagure-webhook/pagure_webhook.service
[1] https://pagure.io/pagure/blob/master/f/files/pagure.spec#_117

It can but doesn't have to be

yup, thanks

I'm not quite sure how to deal w/ the service and the package structure tbh.

Do we put all the "services" into one systemd service? Do we split them?
Same question for the rpm

rebased onto 72c82010783e8a34266100aba1e9b74014eabc28

I'm not quite sure how to deal w/ the service and the package structure tbh.
Do we put all the "services" into one systemd service? Do we split them?
Same question for the rpm

Maybe a good compromise would be to have different systemd services but only 1 rpm. Keeping different services would make it easier to restart a particular service if needed.

After I am not quite sure how you would do that with celery.

After I am not quite sure how you would do that with celery.

Using multiple queues, which iirc is what I started to do here :)

I'm thinking to start migrating more services to celery and solve the packaging structure in a later PR.

Thoughts?

rebased onto 7937d22e5e62221eddabe2ffb9c196ed50256c55

Thanks, let's merge then :)

Pull-Request has been merged by pingou

Metadata