#2917 Add the possibility to mark milestones as active or inactive
Merged by pingou. Opened by pingou.
active_milestones  into  master

Download 2917.patch

By default only the active milestones are shown in the UI but we offer
a button to show them all.
And tickets can only be assigned to active milestones.

Fixes https://pagure.io/pagure/issue/2123

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Still needs some more tests but gives us a basis to review

rebased onto 9b1821ea32ba13af7d3b912684cfa1a75d760d93

Alright, ready for review :)

rebased onto 69d6b8f168c0ee56188d14bf6fc7e97ea51979ba

doc string is wrong here, it should be "not all active" or something like that

I would add an "Active" label on top of the tick box in the setting so it is obvious what the tick box is used for.

Also after a quick test it seems possible to assign an inactive milestone to an issue.

rebased onto c63e078fd2c8ef6ece15d89e7c602ae5ea518db4

docstring and function name as well, thanks

rebased onto 9822ab1eee8cc09a38197e565c47e263b5bc4af0

Also after a quick test it seems possible to assign an inactive milestone to an issue.

Via the UI or the API?
In the UI they are not shown, via the API that sounds right indeed.

rebased onto 0619e565ee26d0ed72e14f852c9bdc4a24ad9458

Ok tested again and inactive milestones are not available in the issue metadata form

:thumbsup:

Thanks :)

Pull-Request has been merged by pingou

Metadata