PR#2936: UI modified so tags with slash or any special character cannot be created -

pagure

#2936 UI modified so tags with slash or any special character cannot be created

Closed Mar 2, 2018 by pingou. Opened Jan 28, 2018 by chocos.

chocos/pagure tags into master

Download 2936.patch

chocos commented Jan 28, 2018

solve issue #1787

batman commented Jan 28, 2018

These ui_ns are required now a days

rebased onto bd1a3abe0434808b719c99d28180e4aa3593d29c

Jan 28, 2018

chocos commented Jan 28, 2018

@batman file updated

pingou commented Jan 31, 2018

You more likely want to do this in the python code in pagure/ui/issues.py as not everyone uses javascript and thus it would be easy to by-pass this :)

lsedlar commented Feb 10, 2018

If user clicks the new tag button twice, there will be two elements with the same id. Better use a class.

Also the validation against a pattern can be done by adding an attribute pattern="[a-zA-Z0-9-_, .]+".

pingou commented Mar 2, 2018

I'm going to take over this one, I have the fix and the test for it ready.

Thanks for starting the work on it.

pingou commented Mar 2, 2018

New proposal at: https://pagure.io/pagure/pull-request/3028

Pull-Request has been closed by pingou

Mar 2, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#2936 UI modified so tags with slash or any special character cannot be created Closed Mar 2, 2018 by pingou. Opened Jan 28, 2018 by chocos. chocos/pagure tags into master

Metadata

#2936 UI modified so tags with slash or any special character cannot be created

Closed Mar 2, 2018 by pingou. Opened Jan 28, 2018 by chocos.

chocos/pagure tags into master