#3000 Migrate the loadjson service to be celery-based
Merged by pingou. Opened by pingou.
merge_loadjson  into  master

Download 3000.patch

This will help migrating pagure to python3 as well as scaling it up
horizontally by adding more workers.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

This is WIP, not ready to be reviewed yet

rebased onto 914ecb682b01e6bd19bf571a3cf95f182cd824fc

rebased onto 05058566fff8074b468acd363d92e4615a4d0e9f

rebased onto 8efc6affac71badc56228a1a63fed14d3a9a2021

Tests are passing now, needs some more testing and I think we're good :)

rebased onto aab91693abf191f2e3d39a8487a4f269c507163d

rebased onto 34e55ec586d148ff022a7394c4eace13cfaa8ad1

The last bit of testing caught one bug but the rest worked, so this is looking good to me :)

1 new commit added

  • Specify which service is logging the action

What are the benefits we will have from this?

Missed the initial comment? :)

rebased onto 891e41df527bd199fc55c5550e8b1ae34cf14db2

maybe we could use logging here instead of print

would this be useful to have in pagure/lib/tasks.py ? if yes maybe this can be move to a more generic module.

Look good to me. Feel free to merge with or without my comments.

prints are shown in the terminal of the user doing the push, I'm not sure logging would

We have this method also present in mail_logging, so maybe we could combine them

rebased onto 50d6b6a3e810e76c0ea3a02e97e61ba656d008c4

:thumbsup:

Thanks! :)

Pull-Request has been merged by pingou

Metadata