pagure

#3003 Check for worker readiness in tests using subprocess
Merged by pingou. Opened by bkabrda.
bkabrda/pagure test-worker-subprocess-ping  into  master

Download 3003.patch

As celery seems to be leaking Redis connections (see [1]), it seems to be best to use subprocess to check for worker readiness (it's a workaround, but the functionality is as good as using celery API directly).

The other commit in this PR is a bit unrelated - it fixes a lot of fails in tests for Pagure's lib package by making sure tasks_services.py module can actually connect to Redis (I think this bug must have been present for some time now, not sure why nobody noticed).

[1] https://github.com/celery/celery/issues/4465

rebased onto 2641c4a117e702c31188653e357c9ee7504cbdfb

1 new commit added

  • Close most of the leaked Redis connections in tests

3 new commits added

  • Close Celery connections in tearDown to not leak them
  • Fix lib tests by reloading tasks_services to get proper redis url
  • Check for worker readiness in subprocess not to leak redis connections

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.