PR#3005: Allow tests to run in virtualenv -

pagure

#3005 Allow tests to run in virtualenv

Merged Feb 28, 2018 by pingou. Opened Feb 25, 2018 by lsedlar.

lsedlar/pagure tests-in-virtualenv into master

lsedlar commented Feb 25, 2018

If celery is installed in virtualenv, it will not be in /usr/bin. We also need make sure to preserve env from parent process and only add the new values (so that PATH adjusted by virtualenv still remains).

This allows me to run all tests:

Ran 895 tests in 9537.060s
FAILED (errors=92, failures=16)

lsedlar commented Feb 25, 2018

This PR conflicts with #3003. I'm happy to rebase if that one is merged first.

rebased onto c94b68376fcbf17467acf7483b569e60b3981f6f

Feb 26, 2018

pingou commented Feb 28, 2018

I'm going to merge this manually to spare you the rebase.

Thanks for this! :)

pingou commented Feb 28, 2018

Commit a3be3b44 fixes this pull-request

Pull-Request has been merged by pingou

Feb 28, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#3005 Allow tests to run in virtualenv Merged Feb 28, 2018 by pingou. Opened Feb 25, 2018 by lsedlar. lsedlar/pagure tests-in-virtualenv into master

Metadata

#3005 Allow tests to run in virtualenv

Merged Feb 28, 2018 by pingou. Opened Feb 25, 2018 by lsedlar.

lsedlar/pagure tests-in-virtualenv into master