PR#3011: Disable setting folders for docs, requests and tickets. Fixes #2991 -

pagure

#3011 Disable setting folders for docs, requests and tickets. Fixes #2991

Merged Feb 27, 2018 by pingou. Opened Feb 26, 2018 by bkabrda.

bkabrda/pagure folders-fix into master

bkabrda commented Feb 26, 2018

This is an attempt to fix #2991 by disabling setting DOCS_FOLDER, TICKETS_FOLDER and REQUESTS_FOLDER. Please consider this a WIP patch, since I'm still going through some test failures and fixing them, so I will be amending. However, the gist of the PR should stay.

pingou commented Feb 26, 2018

There is a section about deprecated options at the end, we probably want to add these there and explain why they got deprecated.

pingou commented Feb 26, 2018

We probably don't want this one upstream :)

bkabrda commented Feb 26, 2018

Good point, I didn't notice that section. I'll do this.

bkabrda commented Feb 26, 2018

Well, that's just an example and I gave it the same value as is in gitolite.rc for gitolite 2 - https://pagure.io/pagure/blob/master/f/files/gitolite.rc#_24 - what do you think would be a better way to handle this?

rebased onto a555968758697738c7e5cdf87ec60881f1164c99

Feb 26, 2018

bkabrda commented Feb 26, 2018

I added a section about the removed values to the deprecated options section and I also fixed last couple failing tests. This is now ready for review as all tests are passing for me.

pingou commented Feb 27, 2018

Alright, let's leave it then

pingou commented Feb 27, 2018

Entier works for me but I'm not sure it's english :D

rebased onto c2891e430cd1317653df6ecbbed66bfe4c016db4

Feb 27, 2018

pingou commented Feb 27, 2018

Note to self, let's add tests for this :)

rebased onto adea204dd0e86891d7e015ef05e57dae4ec5c3f9

Feb 27, 2018

pingou commented Feb 27, 2018

Alright, looks all good to me, thanks! :)