PR#3023: We need to close pagure.REDIS and pagure.lib.REDIS before every test case -

pagure

#3023 We need to close pagure.REDIS and pagure.lib.REDIS before every test case

Merged Mar 1, 2018 by pingou. Opened Mar 1, 2018 by bkabrda.

bkabrda/pagure tests-redis-fix into master

bkabrda commented Mar 1, 2018

Because runtests.sh defines PAGURE_CONFIG to tests/test_config and that file has PAGURE_CI_SERVICES set, pagure.REDIS and/or pagure.lib.REDIS
get set before every test case. Therefore we must make sure they get closed.

pingou commented Mar 1, 2018

Let's rebase but looks fine, are the tests still passing?

rebased onto afb8f60cac3e7a78d548edff08cb5145003b612a

Mar 1, 2018

bkabrda commented Mar 1, 2018

Rebased. I'm running the test suite now, I'm about 30 % through with no failures so far.

bkabrda commented Mar 1, 2018

Test suite finished. I don't see any errors other than couple of flake8 complains not related to my PR.

pingou commented Mar 1, 2018

I'm not even seeing these flake8 errors :(

Thanks for the PR :)

Pull-Request has been merged by pingou

Mar 1, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#3023 We need to close pagure.REDIS and pagure.lib.REDIS before every test case Merged Mar 1, 2018 by pingou. Opened Mar 1, 2018 by bkabrda. bkabrda/pagure tests-redis-fix into master

Metadata

#3023 We need to close pagure.REDIS and pagure.lib.REDIS before every test case

Merged Mar 1, 2018 by pingou. Opened Mar 1, 2018 by bkabrda.

bkabrda/pagure tests-redis-fix into master