#3024 Improve docker-compose and documentation
Merged by pingou. Opened by farhaan.
farhaan/pagure improve-compose  into  master

Download 3024.patch

This commits makes the current docker-compose.yml to work with the latest version of docker-compose, documentation on creating the initial directories are added to the docker-compose section.

Signed-off-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

rebased onto 6b377558ac41dcb7bbeb5943fbf4ae6c3d24fe37

it is missing the read_only set to true here.
I think ../lcl/attachments:/attachments:ro should work

@pingou any reason we used print statement here ?

This isn't quite related to docker :)

One comment and one question :) but looks good otherwise

in a way yes because it is not easy to get stdout using docker-compose.

I'm wondering if this isn't from time where we were using much less logging

Alright, let's rebase and merge :)

well, and fix :)

Awesome I will fix and rebase it :smile:

rebased onto a2549f344788f96c5660b0f5ba0aa28dc61f96ec

got the wrong one :) it needs to be on the worker not the web service

Damn I am really sorry

2 new commits added

  • Replace print with debug logs
  • Improve docker-compose and documentation

:thumbsup:

Thanks! :)

Pull-Request has been merged by pingou

Metadata