#3026 Fix duplicated test names
Merged by pingou. Opened by lsedlar.
lsedlar/pagure duplicate-tests  into  master

Download 3026.patch

This actually causes some of the tests not to run.

This one does not actually pass, but I'm not sure what it's testing.

wow, I did not expect that many :(

I'll check the failing one

It's testing an url that we're getting hit on. Basically it currently triggers a 500 error which sends me an email while we should just send them away.

I'd like to add this to this PR:

diff --git a/ pagure/flask_app.py b/ pagure/flask_app.py
index 5ee403a7..f898d9b6 100644
--- a/ pagure/flask_app.py      
+++ b/ pagure/flask_app.py      
@@ -265,6 +265,7 @@ def set_request():
             )
         if not flask.g.repo \
+                and namespace \
                 and pagure_config.get('OLD_VIEW_COMMIT_ENABLED', False) \
                 and len(repo) == 40:
             return flask.redirect(flask.url_for(

It fixes the test that is currently failing :)

1 new commit added

  • Fix failing test for old commit URL

rebased onto a25e58d40cc5bbc50790d27c379fcb8c847118f7

:fireworks: thanks :)

Pull-Request has been merged by pingou

Metadata