pagure

#3054 Add linking between tickets and pull-requests
Merged by pingou. Opened by pingou.
link_issue_pr  into  master

Download 3054.patch

Fixes #2705

This still requires tests though :)

2 new commits added

  • Add the possibility to link issues to pull-requests
  • Move _get_parent_repo_path to pagure.utils as get_parent_repo_path

Is there a missing migration for the new model? I'm trying to run it locally via docker-compose and getting ProgrammingError: (psycopg2.ProgrammingError) relation "pr_to_issue" does not exist.

Yes indeed, I added the table locally by running the createdb script but it does need a migration, will add it :)

1 new commit added

  • Add an alembic migration to create the pr_to_issue table

rebased onto 56e7d0cd7580969c28a25633814a23febcf27bc1

rebased onto 8c6f32d2644c899ef08be0fd8aa0891989d2f878

1 new commit added

  • Ensure the order is always consistent

1 new commit added

  • Remove all bare except

rebased onto 81aeff3280bbf9da5ecbceece0820ce1bbec78e2

rebased onto ae078d5a8a71ed3733bd2f34a0155c0605ff1bcc

rebased onto d270fd6e3596329df9c10fe9fc4fc36ea4216da4

rebased onto 888d25c03946bff8c9402f6ce513c5d282ddaf6c

Tests running at https://ci.centos.org/job/pagure-pr/67/

5 new commits added

  • Flake8 fixes
  • Ensure variables are instantiated before trying to use them
  • Add an alembic migration to create the pr_to_issue table
  • Add the possibility to link issues to pull-requests
  • Move _get_parent_repo_path to pagure.utils as get_parent_repo_path

s/mentionned/mentioned/

It might be good to pluralize this variable name since it is a list.

Do we want this commit() to be indented, or do you really want it to happen no matter what?

This flush() isn't needed because the commit() below will run a flush() for you.

true

doable

Thanks

Well, it's not really no matter what.

But maybe I could flush here and do the commit closer to the end of the work with the appropriate try/except/rollback

rebased onto b58d7a3ee12647c494338980c7483d46eeb05d65

@bowlofeggs I addressed your first concerns

7 new commits added

  • Rely on the list of branches rather than the .empty attribute
  • Fix typo, variable name and restructure when we commit to the DB
  • Flake8 fixes
  • Ensure variables are instantiated before trying to use them
  • Add an alembic migration to create the pr_to_issue table
  • Add the possibility to link issues to pull-requests
  • Move _get_parent_repo_path to pagure.utils as get_parent_repo_path

LGTM

Thanks! :)

rebased onto 78ba11ddde3bcbfa42b7bef165d9e865950e033b

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.