PR#3059: Enable sending messages to stomp-compliant brokers -

pagure

#3059 Enable sending messages to stomp-compliant brokers

Merged Mar 13, 2018 by pingou. Opened Mar 12, 2018 by bkabrda.

bkabrda/pagure stomp-integration into master

Download 3059.patch

bkabrda commented Mar 12, 2018

This PR enables emitting messages to any stomp-compliant message broker, similar to what currently exists for fedmsg.

rebased onto f9435a9edcb460d622142e9bdec9b9b13ba1766b

Mar 13, 2018

pingou commented Mar 13, 2018

Thanks :)

pingou commented Mar 13, 2018

Commit 631df5bf fixes this pull-request

Pull-Request has been merged by pingou

Mar 13, 2018

pingou commented Mar 13, 2018

Hm, should we include this one only if stomp is configured?

Note: this is also breaking some of the tests

bkabrda commented Mar 13, 2018

Well, fedmsg_notifications: True is also included even if FEDMSG_NOTIFICATIONS is disabled, so I wanted to maintain the same logic here. I'll take a look at the tests.

pingou commented Mar 13, 2018

Good point, in that case I'd adjust both then ^^

Metadata

Assignee

None

Tags

No Tags

pagure

#3059 Enable sending messages to stomp-compliant brokers Merged Mar 13, 2018 by pingou. Opened Mar 12, 2018 by bkabrda. bkabrda/pagure stomp-integration into master

Metadata

#3059 Enable sending messages to stomp-compliant brokers

Merged Mar 13, 2018 by pingou. Opened Mar 12, 2018 by bkabrda.

bkabrda/pagure stomp-integration into master