This PR refactors the CI triggering so that a CI job is not strongly coupled to pull-requests. This is the first step for allowing triggering the CI on commits and via APIs.
Maybe we should check the validity of the pr_id, what do you think?
I'm not sure I fully follow this change, what's the idea?
It is too make the hooks input form consistent with the rest of the settings.
before : https://screenshots.firefox.com/NOlX2sIAhkOR1yae/pagure.io after : https://screenshots.firefox.com/qguV8z8fpW2uY7XH/0.0.0.0
It might be a nicer way to do that, so I open to suggestion.
So the pr_id is currently used to send the cause info to jenkins. That will just be printed out in the jenkins log like Started by 17 where 17 is the pr_id.
cause
Started by 17
I think in the next step when allowing to trigger the ci on commit, we might drop this and always use the last commit hash or mabye the branch name instead.
ok
Ok for the class, I was more worried about the padding-right above tbh, won't that impact other forms somewhere?
This macro is only used by the Hooks form. It used to be imported by other template but it was not used [0].
I think it looks nicer with the padding but I am happy to remove it, if you don't feel that way.
0 - https://pagure.io/fork/cverna/pagure/c/578b5404822e20e17c4456e4e7f4c4b715ded8b9
If you check that it is only used there, then I'm happy with the change, thanks :)
Let's rebase then :)
rebased onto 5df01ee7c7d0d475de970414f188e88941118c0c
rebased onto f5181b58fa312efdb318a9cd58f5496d7420482f
Pull-Request has been merged by pingou
This PR refactors the CI triggering so that a CI job is not strongly coupled to pull-requests. This is the first step for allowing triggering the CI on commits and via APIs.