pagure

#3077 Move the `Add Milestone` button near the top and fix the layout
Merged by pingou. Opened by pingou.
fix_buttons_layout  into  master

Download 3077.patch

This commit makes all buttons at the top (roadmap, add milestone and
report) aligned as they should be.

Fixes https://pagure.io/pagure/issue/2860

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 525ebe257f4d75071d30a61103f22eaaf6c6edd3

So now the Add Milestones button works when the reports button is present. But I was not able to add a new milestone the add new milestone button is not working.

1 new commit added

  • Include the JS code used to add new Milestones and show them all

One more issue while testing :(

When trying to add a milestone my admin session had expired, that correctly redirected me to FAS for login but then the redirect fails with a 405 

Method Not Allowed
The method is not allowed for the requested URL.

I guess we are sending a GET method on the redirect instead of POST to add the milestone.

I can be reproduce by setting ADMIN_SESSION_LIFETIME = timedelta(minutes=1).
Edited by cverna

That's expected. The session times out, you're redirected to the auth server that then redirects you to the same URL using a GET (the auth server can't do POST nor preserve the arguments), thus the error :)

except for that I am :thumbsup: .

Ps: would be nice to find a way to avoid the 405.

rebased onto 1e2a5f27e962567e86f3cdfda13402df587a7fd4

:thumbsup:

Thanks for the review :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.