pagure

#3085 Add preview feature while editing comment.
Merged by pingou. Opened by pingou.
preview_edit  into  master

Download 3085.patch

Fixes https://pagure.io/pagure/issue/1674
Fixes https://pagure.io/pagure/issue/1732
Fixes https://pagure.io/pagure/pull-request/1734

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 32819362714b759fa8da1692e50bc0ee08f1d3e6

This is basically a rebase of https://pagure.io/pagure/pull-request/1734 with a tiny polishing (use of toggleClass)

1 new commit added

  • Add a preview button when editing the initial comment of a PR

rebased onto f04c30522cc6068fc913ef97c9d4593d9e12c91a

Tests running https://ci.centos.org/job/pagure-pr/66/

I recommend naming these vendored libs with their versions. That way if you ever need to update them, the user's browser cache won't keep them on the old (potentially broken) version.

I actually don't follow this suggestion on Bodhi, but it's been on my TODO list.

The non-versioned files are symlinks to the versioned ones so that updating the version is as easy as changing that symlink and doesn't need to go through all the templates to fix the urls.

 
jquery.atwho-1.5.1.css
jquery.atwho-1.5.1.js
jquery.atwho-1.5.1.min.css
jquery.atwho-1.5.1.min.js
jquery.atwho.css -> jquery.atwho-1.5.1.css
jquery.atwho.js -> jquery.atwho-1.5.1.js
jquery.atwho.min.css -> jquery.atwho-1.5.1.min.css
jquery.atwho.min.js -> jquery.atwho-1.5.1.min.js

rebased onto 63de36149f8451c1ceb86e51360d0a066f593084

it would be nice if we could avoid duplicating this code. But I guess that true for a lot of the JS we have.

One comment but not blocking, :thumbsup:

I'm going to merge as is as I'd like to have this in the upcoming beta release, but let's see if we can refactor this for the final release :)

rebased onto c2137d23c89202b12b52b961b9a8440ce624ee72

For tracking purposes: https://pagure.io/pagure/issue/3131

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.