PR#3115: Support adding comments to issues without reloading and without the SSE -

pagure

#3115 Support adding comments to issues without reloading and without the SSE

Closed Apr 3, 2018 by pingou. Opened Mar 30, 2018 by pingou.

no_sse_issue into master

pingou commented Mar 30, 2018

Note this currently only supports adding new comments, no
metadata-changes.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

pingou commented Mar 30, 2018

This is very much a proposal, I'm not sure it should be merged.

The fact that only new comments are being considered and not meta-data changes make the behavior inconsistent, so I wonder if for issues we shouldn't just reload the entire page as we do today if the SSE is down.

I've looked at using the same strategy for the meta-data but it's going to be rather hard to do.

I'm actually included to not merge this.

Thoughts?

pingou commented Apr 3, 2018

Based on the discussion in IRC, I'm going to close this PR as is.

Thanks for your inputs @abompard and @cverna !

Pull-Request has been closed by pingou

Apr 3, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#3115 Support adding comments to issues without reloading and without the SSE Closed Apr 3, 2018 by pingou. Opened Mar 30, 2018 by pingou. no_sse_issue into master

Metadata

#3115 Support adding comments to issues without reloading and without the SSE

Closed Apr 3, 2018 by pingou. Opened Mar 30, 2018 by pingou.

no_sse_issue into master