pagure

#3145 Make sure we rollback session on task failures
Merged by pingou. Opened by bkabrda.
bkabrda/pagure task-session-rollback  into  master

Download 3145.patch

This is to make sure that open uncomitted transactions aren't left hanging, which would make subsequent tasks fail

Note: this is a followup to https://pagure.io/pagure/c/efeaa68374a647a91268fd6af3564d685d155376?branch=master, which seems to have only fixed a part of the actual issue, which was running out of DB connections. If there's a problem in the worker and it starts raising (e.g. because of faulty storage), it doesn't run out of DB connections now, but it starts complaining about uncommitted transaction hanging and will never recover from it.
This patch fixes that issue (for good, I hope).
Edited by bkabrda

Eh, we probably want to reraise the exception, too :) Let me fix that...

rebased onto 850066a899755489b6fc00a8dd0988a5ccdebd56

Nice patch, let's rebase and merge :)

rebased onto c40ba05b6736fb42574e204ba5f1ebc4193ecf3c

Rebased, thanks.

It's me ! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.