3025

Added an a setting to the Project, which is responsible for whether we send a notification with or without a diff. Put maximum number of characters in email to 500000.
I didn't actually manage to send myself an email locally (I guess because there is not smtp server?), but I could see the updated emails with diff in the logs.

pingou commented Apr 16, 2018

I'd rather we split like:

with_diff = repo_to.settings.get(
    'notify_on_pull-request_with_diff_flag')

pingou commented Apr 16, 2018

There is not flag involved there, what about: 'Include_diff_in_pull-request_notification' ?

pingou commented Apr 16, 2018

If there is no diff, this line will look odd.

Should we create the body of the email, check if there is a diff and if so extent the email?

pingou commented May 2, 2018

ping?

pingou commented May 16, 2018

Going to close this PR.

There was no update in the last month.

If you feel like working on this again, please open a new one :)

Pull-Request has been closed by pingou

May 16, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#3162 Add an option to include diff in pull request notification Closed May 16, 2018 by pingou. Opened Apr 15, 2018 by anar. anar/pagure notify_with_diff into master

3025

Metadata

#3162 Add an option to include diff in pull request notification

Closed May 16, 2018 by pingou. Opened Apr 15, 2018 by anar.

anar/pagure notify_with_diff into master