As noted in the doc, this is useful when scaling Pagure server to multiple instances, since these instances all need to access the same session key/value pairs.
I think we may be better to simply add a try/except block and document that if flask-session is installed we will use it and that it is necessary for using pagure across multiple machines.
I don't think adding a configuration key for this makes sense
Ok, I can do that. What would be the best place to put the docs about this feature then?
I was wondering the same.
I wonder if we shouldn't start a documentation page about scaling/optimizing a pagure set-up (with splitting the tasks over multiple queues, depending on flask-session, using compile-1...). What do you think?
Yeah, that sounds like a good idea. Do we want to do this right now? I'm thinking that I could just add SESSION_TYPE (which is the key that triggers initialization of the whole flask-session machinery) to the default config and also to the doc and consider this documented... I don't feel that starting such documentation effort really fits into this PR (nor do I have time to work on that ATM).
SESSION_TYPE
I'd be ok with that :)
I think we don't even need to put it in the default_config.py, just in the doc is sufficient for now I think.
Ok, makes sense.
rebased onto 96fbcba2ce3728bd93368adcd4b8f20ca6d9c314
:thumbsup: thanks :)
Commit 9c176a3d fixes this pull-request
Pull-Request has been merged by pingou
As noted in the doc, this is useful when scaling Pagure server to multiple instances, since these instances all need to access the same session key/value pairs.