Let's use the full name: reaction

We'll need to adjust this ;-)

Is this way of storing the reactions reasonable?

Looks fine to me :)

If it used user ids instead, it could display up-to-date name. But if a user is deleted, it would be more tricky. (Can a user be deleted? What happens to their comments then?)

Let's rely on username, then there is no need to update anything. Also, we can "fix" this by not listing all the usernames, imagine if 100 people react on 1 comment... :)

Is a predefined list of reactions good enough? Or should it support any emoji as suggested by @jflory7?

How hard would it be to change? Emoji support is tempting but I'm seeing our competitor is offering only 1 reaction/user in a restricted set.

Should only one reaction per comment per user be allowed?

See above, open to more suggestions :)

Thanks for the feedback!

How hard would it be to change? Emoji support is tempting but I'm seeing our competitor is offering only 1 reaction/user in a restricted set.

It should be doable. I just need to figure out how to put the autocomplete field into the dropdown in a reasonable way. I'll try to get something working over the weekend.

I'm not sure if multiple reactions from the same user are a good thing. If it's used for voting, some could fake multiple votes by using different emoji (:thumbsup: :100: :heart: :hearts: :heartbeat: :heartpulse: :two_hearts:).

Updated to support any emoji as reaction. There is still a predefined list for easy access (I wouldn't want to type the name all the time). One user can send multiple reactions to one comment. Only 10 people for each reaction should be displayed.

Further issues to resolve:

• make it work for pull request comments
• the emoji selector dropdown is displayed below the search entry
• write some tests
• try and make it look more polished

Not working and I think it's fine:

• reactions are not updated live via SSE; users must refresh page
• reaction added via javascript do not get username of current user in the tooltip

Now it works for pull request comments as well.

Now only tests are missing.

is the idea here to have a set of reactions? or just let a user do any emoji?

If any emoji, what is the difference between a reaction, and just adding an emoji as a comment. /me is kinda leaning towards having a subset of reactions rather than any emoji (which also could be bad for community -- :poop: )

Originally I started with a set of allowed reactions, then extended it into allowing any emoji. Even if that is allowed, I would want to keep a select few easily accessible.

I'm starting to think that any emoji is not a good idea because it causes a few issues: the way it works now emojione only gives us the code for the symbol, not any name. Therefore it's rather inaccessible, as the best textual representation we can do is something like 1F4A9. With a selected list we could know that is actually a pile of poop. This is problematic for vision impaired users and also for exposure in the API.

If any emoji, what is the difference between a reaction, and just adding an emoji as a comment.

Right now the difference is that e-mails are not sent for reactions (probably good), it will not show up in the heatmap on user page (probably should be fixed), and it will display differently. Otherwise no difference.

Changes since last version:

• there are tests now :smile:
• I removed the arbitrary emoji picker again
• which enabled exposing the reactions via API

The current code doesn't work for me, it looks like the CSRF is missing from the http call

CSRF token is now fixed.

Looks like the tests aren't passing :(

Yes, I'll resolve that today evening.

I'm running them right now :)

Pretty please pagure-ci rebuild

Pretty please pagure-ci rebuild

One more attempt...

Pretty please pagure-ci rebuild

Locally the tests are finally passing :)

And they pass here too!

:thumbsup: :100: