From 21b4692da81f04d803ed2ed7a1542528f8ddbc87 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Aug 08 2015 14:41:36 +0000 Subject: [PATCH 1/2] Ensure there is a repo before trying to access it --- diff --git a/pagure/templates/repo_master.html b/pagure/templates/repo_master.html index a60eccf..c0c5e58 100644 --- a/pagure/templates/repo_master.html +++ b/pagure/templates/repo_master.html @@ -39,7 +39,7 @@ repo=repo.name) }}">Overview - {% if config['DOC_APP_URL'] and repo.settings.get('project_documentation', True) %} + {% if config['DOC_APP_URL'] and repo and repo.settings.get('project_documentation', True) %}
  • Docs
  • @@ -60,14 +60,14 @@ repo=repo.name) }}">Tags - {% if repo.settings.get('issue_tracker', True) %} + {% if repo and repo.settings.get('issue_tracker', True) %}
  • Issues
  • {% endif %} - {% if repo.settings.get('pull_requests', True) %} + {% if repo and repo.settings.get('pull_requests', True) %}
  • @@ -76,7 +76,7 @@
  • {% endif %} - {% if repo.forks %} + {% if repo and repo.forks %}
  • From 0171c3f250aebd810fd1c9738211c71753cac485 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Aug 08 2015 14:41:47 +0000 Subject: [PATCH 2/2] Return a 404 error if we can't find the repo asked --- diff --git a/pagure/ui/repo.py b/pagure/ui/repo.py index 7d01e4f..9d6364e 100644 --- a/pagure/ui/repo.py +++ b/pagure/ui/repo.py @@ -1372,6 +1372,10 @@ def view_docs(repo, username=None, filename=None): """ Display the documentation """ repo_obj = pagure.lib.get_project(SESSION, repo, user=username) + + if not repo_obj: + flask.abort(404, 'Project not found') + return flask.render_template( 'docs.html', repo=repo_obj,