From 01f802c944557274e218e5e1f25df43120dc2cba Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Jun 11 2018 15:49:40 +0000 Subject: Remove blank cell in the No issues found row in roadmap page Signed-off-by: Chenxiong Qi --- diff --git a/pagure/templates/roadmap.html b/pagure/templates/roadmap.html index 1ceefff..0e319c1 100644 --- a/pagure/templates/roadmap.html +++ b/pagure/templates/roadmap.html @@ -121,7 +121,7 @@ {% endif %} {% else %} - No issues found + No issues found {% endfor %} diff --git a/tests/test_pagure_flask_ui_roadmap.py b/tests/test_pagure_flask_ui_roadmap.py index cb5d84a..5c0d36a 100644 --- a/tests/test_pagure_flask_ui_roadmap.py +++ b/tests/test_pagure_flask_ui_roadmap.py @@ -672,6 +672,30 @@ class PagureFlaskRoadmaptests(tests.Modeltests): self.assertEqual(1, output_text.count( 'title="Issue blocking one or more issue(s)')) + @patch('pagure.lib.git.update_git') + @patch('pagure.lib.notify.send_email') + def test_correct_colspan_in_no_issues_found_row( + self, send_email, update_git): + send_email.return_value = True + update_git.return_value = True + + tests.create_projects(self.session) + tests.create_projects_git( + os.path.join(self.path, 'repos'), bare=True) + + # Create issues to play with + repo = pagure.lib.get_authorized_project(self.session, 'test') + repo.milestones = {'0.1': ''} + self.session.commit() + + user = tests.FakeUser() + user.username = 'pingou' + with tests.user_set(self.app.application, user): + output = self.app.get('/test/roadmap') + output_text = output.get_data(as_text=True) + self.assertEqual(1, output_text.count( + 'No issues found')) + if __name__ == '__main__': unittest.main(verbosity=2)