:thumbsup:

Do you have an idea of when the mail_id isn't being set?

I've observed this problem recently as well, I don't know what causes it. But it does prevent local new user creation. :(

I've observed this problem recently as well, I don't know what causes it. But it does prevent local new user creation. :(

This seems like a bug, basically I'm wondering if we're not fixing the symptom of the bug rather than its cause.

I'm also not fan of this as we suddenly hash only the salt which is quite the opposite of what the goal of the salt is

I haven't tracked that down. It happened when I tried to create a local user, too.

Reading the code and function definition, it seems not specifying the mail_id is valid, in that case I propose we just skip the entire block.

If there is no mail_id header, there is no point to set the Reply-To or a Mail-Followup-To headers as well

Looks like jenkins is unhappy about the flake8 check

Pretty please pagure-ci rebuild

the last jenkins task tied out (#422). does this work as part of a comment, too ?
pretty please pagure-ci rebuild

@karsten pagure-ci should rebuild when you rebase and force push too.

should rebuild when you rebase and force push too.

Should but this seems to be broken in 4.0.3 (fixed in git already though)

Running the tests locally :)

I'm going to merge this one manually, tests are passing for me here :)

Commit 63175dbf fixes this pull-request