Maybe we could use status and user here, I feel that watch_status and user_watching is a little bit redundant, since the endpoint name is giving the needed context.

should it be 3 here ? :)

should this be check just after line 94 ?

should we raise an invalid request exception here if watch_status is None ?

A few comments but looks good. Oh and some tests are failing :P

Agreed, but I wanted to distinguish the user whose watch status is being changed vs the username of the user who forked the project and I felt like having two fields: user and username may be too close to each other

Quite possibly:)

We could

pagure.lib.update_watch_status() takes care of that for us :)
(avoids duplicating code)

oh yes, that's a valid point, since the api endpoint is watchers/update maybe watcher would work ? but feel free to keep it as it is :)

+1

watcher and status it is :)

LGTM :)

Jenkins caught an typo :)

Pretty please pagure-ci rebuild

+1

Thanks for the review :)