#3323 Migrate away from csrf_enabled which is deprecated upstream
Merged by pingou. Opened by pingou.
fix_deprecation_warning  into  master

Download 3323.patch

Fixes https://pagure.io/pagure/issue/3284

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Pretty please pagure-ci rebuild

:thumbsup:

rebased onto b8e6b6d5ad07e38713180e7231bb0fd78da9d07c

Thanks for the review :)

Pull-Request has been merged by pingou

I think this might have broken API.

$ curl -H "Authorization: token …" http://localhost:5000/api/0/new -F name=api-test -F description=api-test 
{
  "error": "Invalid or incomplete input submitted", 
  "error_code": "EINVALIDREQ", 
  "errors": {
    "csrf_token": [
      "CSRF token missing"
    ]
  }
}

Nevermind. I just needed to update flask-wtf… #3331

Do you know which version you had before?

I'm running F27 and the tests are passing so either the tests aren't doing what they ought to do, or there is something else going on

I use: python-flask-wtf-0.10.0-9.fc27.noarch

I had 0.10.0, but not sure what the exact release was. And the tests were not passing for me.

With python-flask-wtf-0.10.0-9.fc27.noarch the tests are failing (running using the run-tests-docker.py script.

With python-flask-wtf-0.10.0-9.fc27.noarch the tests are failing (running using the run-tests-docker.py script.

Hm, this is odd, I can reproduce it now, bummer!
I'll look into this if no-one beats me to it as it will impact us in prod :s

Metadata