pagure

#3328 Only display SSH URL for repo if SSH key is uploaded and gitolite config is compiled
Merged by pingou. Opened by bkabrda.
bkabrda/pagure clone-url-display  into  master

Download 3328.patch

As a usability improvement, I'd like to propose that url for SSH cloning is only displayed when:

  • Gitolite config for the repo is compiled (== repo doesn't have read_only set to true)
  • User has an ssh key uploaded

This is based on feedback from several users who had problems with cloning as one of the above conditions wasn't met and it wasn't obvious for them.

The two different messages that may show up instead of the SSH url deserve some UI love, I'm open to suggestions here.

This is a poorly named setting.

I'd probably suggest ALWAYS_RENDER_SSH_CLONE_URL or something similar.

And depending on the name, obviously adjust the default setting.

I think @ngompa has a point regarding the variable name, and we'll need tests :)

Agreed and thanks for the suggestion. I'll also work on tests.

How about some CSS, any suggestions there? I don't feel like this is the best way to present this information, but don't have a good idea on improving it.

@bkabrda do you have a screenshot of how you are presenting the information at the moment?

@ryanlerch here are the two variants:

  • No ssh key uploaded for user: https://bkabrda.fedorapeople.org/pagure-no-ssh-key.png
  • Project is readonly: https://bkabrda.fedorapeople.org/pagure-readonly.png

rebased onto 0d55a6f9e4d4db6356b1d344d7adf47499142001

1 new commit added

  • Inject git_url_ssh to all templates rendered, since a lot templates are using it

2 new commits added

  • Inject git_url_ssh to all templates rendered, since a lot templates are using it
  • Only display SSH URL for repo if SSH key is uploaded and gitolite config is compiled

rebased onto db523180467c191c79d63b4c4d3dccd4842a06b9

rebased onto 9e14c88820be66b1c53d07721fa164aeb4bd7660

running the tests locally :)

Tests passed :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.