Obviously, it looks fine, code-wise.

But what do these do?

What do what do?

I don't know what "Reorder" or "Active" means in the context of milestone/roadmap.

You can order the milestones in the settings and make them active or inactive (ie: they show up in the drop-downs or not)

Why is that in Settings and not in the Milestones/roadmap view itself?

Regardless of the answer to this question, :thumbsup: for merge.

Why is that in Settings and not in the Milestones/roadmap view itself?

The roadmap view shows you the roadmap itself, adding milestone, ordering them and select which are active or not are in the settings of the project. This makes sense to me, does it not for you?

Not really, no. I actually usually expect to interact with these things from within the main view (i.e. inline). This is how that stuff works in GitHub, GitLab, and even dedicated project management kanban boards like Taiga and Trello.

If I have permission to edit and manipulate it, I can there, otherwise it's view only.

@ngompa yeah, i had that idea when re-doing the milestones.

IMHO, it is worth opening an RFE for it.

I left those parts as-is in the re-do because they were pretty complicated, but def a good idea to move the adding milestones and moving them around into the main UI imho.

Tests are passing, let's open a RFE to improve the UX and merge this in the mean time :)

Thanks for the review :)

RFE opened: https://pagure.io/pagure/issue/3359