pagure

#3371 Fix messed up custom fields in settings
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure fix-custom-fields-settings  into  master

Download 3371.patch

The new tabbed layout of the settings page changed the way
we add rows to some of the settings that use rows, like priorities
and the custom fields. This new way used a hidden blank-field that
allowed us to duplicate. However, this field was sticking around when
submitting the form, and was causing the custom fields to not be
submitted propertly to the post call. This PR uses javascript to remove
the hidden field from the form before it is submitted.

Relates to #3366

Signed-off-by: Ryan Lerch rlerch@redhat.com

Nice and easy, thanks

Note: do we use the same mechanism elsewhere? Do we need to adjust them there as well?

Pull-Request has been merged by pingou

We only use it here in the settings. And the ja I added works for all the blank fields on that page.

Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.