pagure

#3422 Fix logging and the SMTPHandler
Merged by pingou. Opened by pingou.
fix_logging  into  master

Download 3422.patch

With this, we now have the SMTPHandler handler properly configured and
running. It sends email on exception both for the flask application as
well as for the different workers.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto b22f5287733ecf9a4a514b45ec0933c67c37d947

Pretty please pagure-ci rebuild

Why is most of this in default_config.py? With the exception of the mail_host, fromaddr and toaddrs, it should all be fixed rather than configurable...

The entire logging config is...configurable and this comes with a default configuration which is in the default_config.py :)

rebased onto 4ecd3d6d53b5f09692f693d000d58cd8270cb7a3

rebased onto b22f5287733ecf9a4a514b45ec0933c67c37d947

I would suggest keeping the default config with email disabled, since that's not the usual way for Linux software to report errors.
Other than that, the patch looks sane.

rebased onto 24747eeeb8ec4a1ef718a0ec1ff4ac6e8f3e69d4

Thanks for the review @puiterwijk :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.