#3489 update subscriber count and avatar on issue and PR pages
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure subscribers-js  into  master

Download 3489.patch

adds code to update the javascript to change the subscriber count and remove or add the user's avatar when subscribing or unsubscribing from an issue or pull request.

Fixes #3367

rebased onto 5a5f1b72e99eeb1035974a4314b6c9a18c16f960

Note that if you unsubscribe it will change the count but won't remove the avatar.

Otherwise looks fine to me, let's see what jenkins says :)

1 new commit added

  • Fix providing the username and avatar when subscribing on issues/PRso

@pingou here is where the avatar is removed when unsubbing from an issue

@pingou here is where the avatar is removed when unsubbing from a PR

3 new commits added

  • Fix providing the username and avatar when subscribing on issues/PRso
  • update subscriber count and avatar on pull request page
  • update subscriber count and avatar on issue page

rebased onto ccb2e086bbf8264ed5e3dfd3faca28fb6faf2218

I wasn't working for me because the API endpoint wasn't returning the user's username

:thumbsup:

3 new commits added

  • Fix providing the username and avatar when subscribing on issues/PRso
  • update subscriber count and avatar on pull request page
  • update subscriber count and avatar on issue page

3 new commits added

  • Fix providing the username and avatar when subscribing on issues/PRso
  • update subscriber count and avatar on pull request page
  • update subscriber count and avatar on issue page

The tests passed \ó/

Let's merge before they change their mind :)

Pull-Request has been merged by pingou

Metadata