Let's not rely on external sources, even for the default theme

Let's drop this if not needed :)

This should be pointing to fedora-bootstrap 1.2.0.

This should be pointing to fedora-bootstrap 1.2.0.

The code looks good, but could you please split the commits so that it's easier to see how a theme could be added?

That is, a commit that adds theme support and a default theme with bootstrap 4 (though I think the vanilla bs4 theme is a bit too plain...), and a commit that adds the pagureio theme.

That way, it's easy for people to see how to add their own themes (like Mageia and openSUSE ones...).

Also, can we have some way to allow user-configurable light/dark variants?

I actually don't have a problem with this, CDNs would be more efficient than local serving in most cases anyway. If people want to adjust this for their own setups, it's easy to do.

The code looks good, but could you please split the commits so that it's easier to see how a theme could be added?
That is, a commit that adds theme support and a default theme with bootstrap 4 (though I think the vanilla bs4 theme is a bit too plain...), and a commit that adds the pagureio theme.
That way, it's easy for people to see how to add their own themes (like Mageia and openSUSE ones...).

It's kinda hard to make a stand-alone commit here, i kinda did the bare minimum to make the themes, and add the support.

Documentation will come in a later commit.

Also, the current default in the config for pagure is 1.1.1, so i just stuck with that.

we can bump the fedora-bootstrap version in a seperate PR, when i can check that the changes it brings in

ok, fair

I think @ryanlerch's point make sense, doing this in a separate PR is likely safer :)

As long as we have good doc, I'm fine with having this one commit, I expect people will look more at the files and directory structure than the commit itself to be honest.

Also, can we have some way to allow user-configurable light/dark variants?

This is tracked in https://pagure.io/pagure/issue/3395 which you opened ;-)

I'm fixing the broken test and seeing if there are more :)

Feedback from Stasiek Michalski from openSUSE:

would be nice if navbar was changable

Feedback from Stasiek Michalski from openSUSE:

would be nice if navbar was changable

The themes use flask blueprints, so you can overwrite an entire template file by just putting a template of the same name in the templates dir of the theme. Currently the masthead is in the master template, but that can easily be broken out into another template in another PR.

okies, updated the original commit to remove the commented out code, and add stock bootstrap in the static dir of the default theme.

Pretty please pagure-ci rebuild

This approach looks good to me, and pending successful test run, I'd say it's good to merge.

All green, let's merge :)