pagure

#3494 paginate /api/0/projects by default
Merged by pingou. Opened by karsten.
karsten/pagure issue-3403  into  master

Download 3494.patch

On pagure instances with a huge number of projects querying /api/0/projects
could lead to out of memory errors. This change enables paginating the
output by default, the old behaviour can be achieved by setting page=0

Signed-off-by: Karsten Hopp karsten@redhat.com

This should fix the initial request in issue #3403. The remaining request that was added in a later comment about paginating

/{repo}/pull-requests
/{repo}/issues
/user/{username}/issues
/user/{username}/requests/filed
/user/{username}/requests/actionable

is not part of this PR.

rebased onto 68dfad2d50cd3863371a69fdd43af8a2cc42db90

Honestly, if we break backward compatibility, I'd rather we don't support non-paginated results at all.

I can see a use-case for unpaginated output if you have some scripts to gather data from pagure.
OTOH it is really bad that every user can bring down larger pagure instances with a simple request to the API.
I'll remove the unpaginated output and leave it to the scripts to handle getting all pages.

rebased onto c8a65e7abc01bd0ccac007c605aac9e74f34ae60

rebased onto cdd41cc875714df27ec599cc4b1bc6a27f77984e

rebased onto 7cd7275fb9e6b83a9659ba5a7e41ffdfea21fb84

rebased onto cdd41cc875714df27ec599cc4b1bc6a27f77984e

I think we should rephrase this a little bit since it's always on now

rebased onto 250f5dd6047bd3329afdcdcdd082538a9246ed52

rephrased and left out the part about turning pagination on

rebased onto 8e997a63bfd803f8d8bf3e8aac55c2042c67b082

1 new commit added

  • make tests fail if pagination is not present

rebased onto a5d5f1bf4c1dd37cc213ebe01127cd6cd8e29932

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.