PR#3551: Allow deleting branches in forks regardless of ALLOW_DELETE_BRANCH -

pagure

#3551 Allow deleting branches in forks regardless of ALLOW_DELETE_BRANCH

Merged Aug 22, 2018 by pingou. Opened Aug 21, 2018 by pingou.

delete_branch_fork into master

Download 3551.patch

pingou commented Aug 21, 2018

Basically, even if main project are not allowed to delete branches
forks should be.

Fixes https://pagure.io/pagure/issue/3547

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

ngompa commented Aug 21, 2018

:thumbsup:

rebased onto 51d9c05ebccb7c8f89cf830f1acb6ca8d8aa120a

Aug 22, 2018

karsten commented Aug 22, 2018

:thumbsdown:
I have

ALLOW_DELETE_BRANCH = False

in pagure.cfg, deleting branches is disabled, the buttons don't show up. But they don't show in the fork either where they should. It is questionable if deleting branches that are in the main repo should be allowed to be deleted in the fork, but this also doesn't work for branches that are only in the fork.

pingou commented Aug 22, 2018

ah, I missed the template... Thanks @karsten

rebased onto 4497e257c3eda9c8614f67a44b0da23b1f1af367

Aug 22, 2018

pingou commented Aug 22, 2018

Code and tests adjusted for this :)

karsten commented Aug 22, 2018

:thumbsup:
LGTM

pingou commented Aug 22, 2018

Thanks for the reviews! :)

Pull-Request has been merged by pingou

Aug 22, 2018