pagure

#3559 Run black through the sources and enforce it in the tests
Merged by pingou. Opened by pingou.
style_coverage  into  master

Download 3559.patch
no initial comment

hm looks like the changes to tests_requirements doesn't work on jenkins

rebased onto ff105bfee0824becda3c70fd8f2c9bfe1a10f3f5

rebased onto d671065b6e78ffbfd0d834672dc7b2805993bc6e

black requires Python 3.6, I guess that's why it fails on jenkins.

I'll tweak the conditioner so it doesn't trigger on 3.4 but it's annoying then, I'll need to find a way to get back to run as otherwise it'll be hard to enforce it.

6 new commits added

  • Drop pylint and flake8 from tox, they are part of the test suite
  • Fix the regex for the changes made by black
  • Run black over all the sources
  • Enforce running black on the source when the tests are ran with python3
  • Mention black on the contributing doc and adjust wording around pep8
  • Fix ordering of the requirements for testing

rebased onto f34f2213b765ed40f01f090cbd47f2d37f63a351

rebased onto ad091c68d4933b48e9efb29d75cea0e5a57a9ccd

rebased onto 84e06f952bcdeba2f073979121e0d51431318750

rebased onto d5959ab7a5e87bf86181c84475a2c33b288da571

LGTM :black_joker:

\ó/

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.